Skip to content

A11y | Bump design-system for D1 card contrast - #48

Merged
BrianGenisio merged 2 commits into
mainfrom
chore/ds-bump-a11y-d1
Aug 28, 2026
Merged

A11y | Bump design-system for D1 card contrast#48
BrianGenisio merged 2 commits into
mainfrom
chore/ds-bump-a11y-d1

Conversation

@BrianGenisio

Copy link
Copy Markdown
Contributor

Summary

Closes #30. This app now consumes the design-system D1 Horizontal Cards change: inactive card text stays at ≥4.5:1; chrome (inset stroke vs drop shadow) marks the centered card.

Also records D2 as closed (PR #46) on the issue map. That number is not on the D1 or bump D1 rows.

Changes

Submodule public/design-system points at da75b17 (DS PR #31). No app widget changes.

Characterization locks the inactive-card rule so it cannot regain opacity, and so cards are not aria-hidden.

Axe floor color-contrast is 5 → 1. Matching empty is clear in both themes. The remaining node is the Sort empty-dropzone placeholder (Body-Lighter), which is not an audit ID.

Test plan

  • npm test (includes D1 characterization)
  • npm run a11y:ci on a dedicated examples port (matching-empty light and dark had 0 violations)
  • Optional: /play with matching.md, confirm side cards still read as side cards and text is full contrast

Brian Genisio and others added 2 commits August 28, 2026 12:00
Co-authored-by: Cursor <cursoragent@cursor.com>
Point the submodule at the merged Horizontal Cards chrome fade.
Characterization locks full-contrast inactive text. Matching empty
axe color-contrast is gone; the floor is the Sort empty-dropzone
placeholder.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 79bd7f47-d15f-40b2-adc8-b6a5d51164e4

📥 Commits

Reviewing files that changed from the base of the PR and between a35aebd and 41a1969.

📒 Files selected for processing (4)
  • a11y-audits/8-13-26/resolution-plan.md
  • a11y-audits/tools/axe-baseline.json
  • public/design-system
  • test/a11y-characterization.test.js

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The design-system submodule now references the D1 revision. A characterization test verifies inactive horizontal cards use full-contrast styling and do not set aria-hidden. The axe baseline records fewer color-contrast findings and a refreshed timestamp. The accessibility resolution plan reflects the updated D1 and D2 status.

Merge Risk: ⚪ Minimal · up to 41a19

This PR updates the design-system reference and accessibility coverage for D1 card contrast without changing app widget behavior; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the accessibility-related design-system bump for D1 card contrast.
Description check ✅ Passed The description directly explains the D1 design-system update, accessibility coverage, Axe baseline change, and test results.
Linked Issues check ✅ Passed The PR satisfies issue #30 by updating the submodule to the D1 revision, preserving inactive-card accessibility behavior, clearing the matching-empty findings, and documenting the required test covera…
Out of Scope Changes check ✅ Passed The changes remain within scope. They update the D1 submodule, add focused characterization coverage, adjust the related accessibility baseline, and update tracking documentation.
Full details: Linked Issues check

Explanation

The PR satisfies issue #30 by updating the submodule to the D1 revision, preserving inactive-card accessibility behavior, clearing the matching-empty findings, and documenting the required test coverage.


Comment @coderabbitai help to get the list of available commands.

@BrianGenisio
BrianGenisio merged commit aefed73 into main Aug 28, 2026
3 checks passed
@BrianGenisio BrianGenisio mentioned this pull request Aug 28, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[a11y] Bump design-system after D1 (Horizontal Cards opacity)

1 participant