A11y | Bump design-system for D1 card contrast - #48
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Point the submodule at the merged Horizontal Cards chrome fade. Characterization locks full-contrast inactive text. Matching empty axe color-contrast is gone; the floor is the Sort empty-dropzone placeholder. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe design-system submodule now references the D1 revision. A characterization test verifies inactive horizontal cards use full-contrast styling and do not set Merge Risk: ⚪ Minimal · up to This PR updates the design-system reference and accessibility coverage for D1 card contrast without changing app widget behavior; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The PR satisfies issue Comment |
Summary
Closes #30. This app now consumes the design-system D1 Horizontal Cards change: inactive card text stays at ≥4.5:1; chrome (inset stroke vs drop shadow) marks the centered card.
Also records D2 as closed (PR #46) on the issue map. That number is not on the D1 or bump D1 rows.
Changes
Submodule
public/design-systempoints atda75b17(DS PR #31). No app widget changes.Characterization locks the inactive-card rule so it cannot regain
opacity, and so cards are notaria-hidden.Axe floor
color-contrastis 5 → 1. Matching empty is clear in both themes. The remaining node is the Sort empty-dropzone placeholder (Body-Lighter), which is not an audit ID.Test plan
npm test(includes D1 characterization)npm run a11y:cion a dedicated examples port (matching-emptylight and dark had 0 violations)/playwithmatching.md, confirm side cards still read as side cards and text is full contrast