A11y | Add a designed focus ring on blanks and toolbar tools - #66
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdded Comment |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #57. FIB blanks and toolbar tools use the same two-tone keyboard ring as Matching and MCQ, so the indicator is not UA-outline-only. Matching still uses
:focuson purpose.Also records A13 as closed (PR #65) on the issue map. That number is not on the A20 row.
Changes
.blank:focus-visibleand.global-toolbar-tool:focus-visibleget the Neutral-1450 / Neutral-00 stacked ring and a transparent outline for forced-colors. These controls are not scripted-focus widgets, so:focus-visibleis the right trigger.Test plan
npm test— A20 characterizationfib-simple.md: both rules are in the live CSSOM with the two-tone tokens; Matching:focusunchangedneeds-manual-verify)