Skip to content

A11y | Mention the Sort keyboard path - #68

Merged
BrianGenisio merged 2 commits into
mainfrom
fix/a11y-sort-keyboard-copy
Sep 2, 2026
Merged

A11y | Mention the Sort keyboard path#68
BrianGenisio merged 2 commits into
mainfrom
fix/a11y-sort-keyboard-copy

Conversation

@BrianGenisio

Copy link
Copy Markdown
Contributor

Summary

Closes #51. Sort instructions now include the keyboard path that already exists, so 2.5.7 is discoverable (3.3.2).

The line is the confirmed P11 sentence: “Click or drag the items onto the cards above, or select an item and press Enter on a card.”

Also records A12 as closed (PR #67) on the issue map. That number is not on the A14 row.

Changes

One string in sort.js. Click-to-place, the category-head button (Enter/Space), and drag are unchanged. “Drop items here” and the A21 dropzone token are unchanged.

The A8 characterization lock now asserts the P11 sentence. A14 has its own characterization test for the same copy.

Test plan

  • npm test — A14 and flipped A8 copy lock
  • /play sort-into-boxes.md: new sentence is visible; click-to-place works; activating the category head places the selected chip; drag still places
  • PORT=3010 A11Y_BASE_URL=http://127.0.0.1:3010 SIM_PORT=8081 SIM_ORIGIN=http://127.0.0.1:8081 npm run a11y:ci — baseline stays color-contrast 1
  • VoiceOver / keyboard pass (needs-manual-verify)

Brian Genisio and others added 2 commits September 2, 2026 15:37
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 6a903d22-52ca-4f61-9a43-864e3bce8a52

📥 Commits

Reviewing files that changed from the base of the PR and between 72effde and c982317.

📒 Files selected for processing (3)
  • a11y-audits/8-13-26/wave-4-plan.md
  • public/modules/sort.js
  • test/a11y-characterization.test.js

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The Sort activity instruction now describes selecting an item and pressing Enter on a category card. Characterization tests require the complete keyboard-inclusive sentence and add dedicated A14 coverage. The Wave 4 plan records A12 as completed in PR #67 and identifies A14 as the next work item.

Merge Risk: ⚪ Minimal · up to c9823

This PR adds the existing keyboard path to the sort instructions without changing interaction behavior; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: adding the Sort keyboard path to the accessibility instructions.
Description check ✅ Passed The description accurately covers the Sort instruction update, approved sentence, characterization tests, preserved behavior, and verification status.
Linked Issues check ✅ Passed The changes satisfy issue #51. They add the approved P11 sentence, preserve click, keyboard, and drag interactions, update the A8 characterization lock, add A14 coverage, and leave A21 content unchang…
Out of Scope Changes check ✅ Passed The changes stay within scope. The instruction string and related characterization tests address issue #51. The A12 issue-map update supports the documented accessibility work and does not alter unrel…
Full details: Linked Issues check

Explanation

The changes satisfy issue #51. They add the approved P11 sentence, preserve click, keyboard, and drag interactions, update the A8 characterization lock, add A14 coverage, and leave A21 content unchanged.

Full details: Out of Scope Changes check

Explanation

The changes stay within scope. The instruction string and related characterization tests address issue #51. The A12 issue-map update supports the documented accessibility work and does not alter unrelated Sort behavior or A21 content.


Comment @coderabbitai help to get the list of available commands.

@BrianGenisio
BrianGenisio merged commit be7f812 into main Sep 2, 2026
3 checks passed
@BrianGenisio BrianGenisio mentioned this pull request Sep 2, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[a11y][A14] Sort copy omits the keyboard path

1 participant