A11y | Mention the Sort keyboard path - #68
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (3)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe Sort activity instruction now describes selecting an item and pressing Enter on a category card. Characterization tests require the complete keyboard-inclusive sentence and add dedicated A14 coverage. The Wave 4 plan records A12 as completed in PR Merge Risk: ⚪ Minimal · up to This PR adds the existing keyboard path to the sort instructions without changing interaction behavior; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The changes satisfy issue Full details: Out of Scope Changes checkExplanation The changes stay within scope. The instruction string and related characterization tests address issue Comment |
Summary
Closes #51. Sort instructions now include the keyboard path that already exists, so 2.5.7 is discoverable (3.3.2).
The line is the confirmed P11 sentence: “Click or drag the items onto the cards above, or select an item and press Enter on a card.”
Also records A12 as closed (PR #67) on the issue map. That number is not on the A14 row.
Changes
One string in
sort.js. Click-to-place, the category-head button (Enter/Space), and drag are unchanged. “Drop items here” and the A21 dropzone token are unchanged.The A8 characterization lock now asserts the P11 sentence. A14 has its own characterization test for the same copy.
Test plan
npm test— A14 and flipped A8 copy lock/playsort-into-boxes.md: new sentence is visible; click-to-place works; activating the category head places the selected chip; drag still placesPORT=3010 A11Y_BASE_URL=http://127.0.0.1:3010 SIM_PORT=8081 SIM_ORIGIN=http://127.0.0.1:8081 npm run a11y:ci— baseline stayscolor-contrast1needs-manual-verify)