Birmingham | 26-ITP-May | Ogbemi Mene | Sprint 3 | quote-generator-app - #1336
Open
meneogbemi42-bit wants to merge 3 commits into
Open
Birmingham | 26-ITP-May | Ogbemi Mene | Sprint 3 | quote-generator-app#1336meneogbemi42-bit wants to merge 3 commits into
meneogbemi42-bit wants to merge 3 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
meneogbemi42-bit
changed the title
meneogbemi42-bit
added
the
Needs Review
cjyuan
reviewed
Aug 3, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
JS code looks good.
Note: It is a best practice to respect instructions like // DO NOT EDIT BELOW HERE.
Contributor
There was a problem hiding this comment.
Why rename index.html?
You missed updating this HTML file according to an instruction in readme.md.
Author
There was a problem hiding this comment.
- noted i will not make such mistake again to ignor instructions.
- i have corrected the file name and renamed the title in the file.
cjyuan
added
Reviewed
meneogbemi42-bit
added
🏕 Priority Mandatory
Contributor
|
Changes look good. Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
this PR renames the demo HTML file and adds JS to pick and display a random quote on page load and when the "New quote" button is clicked.