London | 26-ITP-May | Chun Yan Wong | Sprint 2 | Coursework - #1367
Open
cywong-dev wants to merge 16 commits into
Open
London | 26-ITP-May | Chun Yan Wong | Sprint 2 | Coursework#1367cywong-dev wants to merge 16 commits into
cywong-dev wants to merge 16 commits into
Conversation
Replaced for-of loop with for-in loop to iterate over object properties.
Uncommented the loop to display ingredients and removed old console log.
Add validation to the contains function to check if the input is a valid object and if the property exists.
Implement createLookup function to return country-currency pairs.
Enhanced the parseQueryString function to handle empty query strings and duplicate keys. Improved decoding of parameters and ensured proper handling of key-value pairs.
Added tests for handling duplicate keys in query strings.
Added input validation and tallying functionality.
Fix invert function to correctly invert object key-value pairs.
Add input validation and handle empty strings in countWords function.
Fixed the totalTill function implementation to correctly calculate the total amount in pounds from the till object. Added a test case to verify the functionality.
cywong-dev
added
📅 Sprint 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
[X] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
[X] My changes meet the requirements of the task
[X] I have tested my changes
[X ] My changes follow the style guide
Changelist
This PR provides the my answers for the Sprint 2 - Coursework