Fix reserved filename sanitization only matching whole base name - #50
Merged
Merged
Conversation
Reserved Windows device names (CON, AUX, NUL, COM1, ...) were being replaced wherever they appeared as a substring anywhere in a filename, instead of only when they formed the entire base name. This mangled ordinary words like ICON, FALCON, CONSOLE and AUXILIARY, and dropped extra characters adjacent to the reserved word instead of leaving them untouched. Also fixes the reserved-name-with-extension prefix handling, which previously discarded everything after the reserved name (e.g. CON.tar.gz became _CON. instead of _.tar.gz). Fixes #46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reserved Windows device names (CON, AUX, NUL, COM1, ...) were being replaced wherever they appeared as a substring anywhere in a filename, instead of only when they formed the entire base name. This mangled ordinary words like ICON, FALCON, CONSOLE and AUXILIARY, and dropped extra characters adjacent to the reserved word instead of leaving them untouched.
Also fixes the reserved-name-with-extension prefix handling, which previously discarded everything after the reserved name (e.g. CON.tar.gz became _CON. instead of _.tar.gz).
Fixes #46