fix(site): match the lockfile name to package.json - #106
Merged
Conversation
`site/package.json` is `diskern-site`; the lockfile still said `site` in both the root object and `packages[""]`, so npm rewrote those two lines on every install and left a modified file in the working tree. `npm ci` tolerates the mismatch, so CI stayed green and nothing ever surfaced it — it just sat there as a stray hunk waiting to be swept into an unrelated PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
site/package.jsondeclares"name": "diskern-site". The committedsite/package-lock.jsonstill said"site", in both the root object andpackages[""].npm rewrites those two lines on every
npm installinsite/, so everycontributor who touches the site ends up with a modified lockfile they
did not ask for — the kind of stray hunk that gets swept into an
unrelated PR.
npm citolerates the mismatch, so CI stayed green andnothing surfaced it.
Two lines, no dependency changes.
Checklist