fix(rules): anchor system var tmp paths - #93
Open
be-student wants to merge 2 commits into
Open
Conversation
The recursive var/tmp glob also matched user projects and Homebrew state, exposing them as actionable temporary files. Restrict the rule to the Linux and macOS system roots and pin both intended and excluded paths in tests.
This was referenced Sep 7, 2026
Muawiya-contact
requested changes
Sep 7, 2026
Muawiya-contact
left a comment
Muawiya-contact
left a comment
Member
There was a problem hiding this comment.
This one's spot on. Mirroring unix-system-logs is the right shape, and you covered all four cases from the issue plus the macOS path. Rebased and ran it here: fmt, clippy and 57 tests all clean.
Only outstanding thing is the changelog line, same as the other two.
Author
|
Merged current main and moved the changelog entry to Unreleased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81.
What & why
Anchors the actionable
var/tmprule to Linux/var/tmpand macOS/private/var/tmp. User, project, and Homebrewvar/tmppaths now remain unknown instead of being offered for quarantine.Checklist
cargo fmt --alland strict clippy pass fordiskern-coreanddiskern-cli