Release: merge development into beta - #431
Merged
Merged
Conversation
Dependabot proposed stylelint 17 on its own, which cannot work: it takes coordinated bumps, and the one that actually blocks it is easy to miss. - @nextcloud/stylelint-config -> ^3.2.2, the version that peers stylelint ^17.9.1 - stylelint -> ^17.9.1 - stylelint-config-recommended-scss -> ^17.0.1 and -recommended-vue -> ^1.6.1 where this app pins them - stylelint-webpack-plugin -> ^5.1.0 where this app uses it. This is the blocker: 5.0.1 peers stylelint only to ^16, and 5.1.0 is the first release that accepts ^17. The findings stylelint 17 then reports are fixed rather than silenced: `word-break: break-word` is deprecated and `overflow-wrap: break-word` is what it actually meant, the deprecated `clip` property becomes `clip-path`, and stylelint --fix's logical-property rewrites (`text-align: left` -> `start`) are correct for RTL. Verified: npm ci, npm run stylelint and npm run build all exit 0. Co-authored-by: Conduction Release Bot <release-bot@conduction.nl>
Dependabot bumped `@vitest/coverage-v8` to 4 on its own in several apps and left `vitest` and `@vitest/ui` on 3. coverage-v8 4 peers vitest 4.1.11 exactly, so a split trio cannot resolve at all: that is what took launchpad's npm ci from green to red. The three move together here, to 4.1.11, which is the current published version of all of them. Verified: npm install and the app's own test script both exit 0. Co-authored-by: Conduction Release Bot <release-bot@conduction.nl>
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 526/526 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ❌ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-30 12:06 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 526/526 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ❌ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-30 12:50 UTC
Download the full PDF report from the workflow artifacts.
…260830125059 chore(sync): carry beta back into development
E2E went from 127 passed / 0 failed to 127 passed / 11 failed between two runs 36 minutes apart: 10:45 4d3819d @nextcloud/vue 9.9.0 E2E success 11:21 b0a322a @nextcloud/vue 9.11.0 E2E failure Nothing about the tests changed -- both failing specs (conditional-visibility-editor, dashboard-sharing) were last touched on 2026-08-13. What changed is the lockfile. package.json asked for ^9.5.0, so regenerating the lockfile for an unrelated stylelint PR silently moved @nextcloud/vue two minor versions. 9.10.0 reworked NcSelect: fix(NcSelect): floating label design using NcTextField #8570 fix(NcSelect): truncate long selected labels ... #8829 All 11 failures share one signature, and it is not 'element missing'. The locator RESOLVES, Playwright logs 'attempting click action', and then times out on 'waiting for element to be visible, enabled and stable': - waiting for locator('.vs__dropdown-option').nth(2) locator resolved to <li role="option" class="vs__dropdown-option">... attempting click action -> Timeout 10000ms exceeded An option that exists but never settles is what a re-laying-out floating label produces. ~9.9.0 holds the last version whose NcSelect these tests were written against. This is deliberately a PIN, not a fix: adapting the specs to the new NcSelect is real work and should be its own change, made against the new component on purpose rather than as a side effect of a lockfile regeneration. Verified locally: 9.9.0 installed, 682 unit tests pass, format exits 0. The E2E itself only runs in CI, and that is the check this is aimed at. Co-authored-by: Conduction Release Bot <release-bot@conduction.nl>
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 526/526 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ❌ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-30 13:56 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 526/526 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-30 14:20 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated promotion.
developmentholds 1 commit(s)betadoes not.