fix(archival): call a mapper method that exists, and correct a @throws

[rubenvdlinde]

Six calls to MagicMapper::findByUuid() — a method MagicMapper does not have.

Fourteen other mappers define findByUuid, which is exactly what makes the call look correct at a glance. MagicMapper is not one of them; AbstractObjectMapper only declares abstract find / findAll / findMultiple / findBySchema; and neither has __call or a trait supplying it.

The failure mode is worse than a 404

Call to undefined method raises a PHP Error, and Error does not extend Exception. So the

} catch (\Exception $e) {
    return new JSONResponse(["error" => "... not found"], 404);

wrapped around every one of these never catches it. Five archival endpoints and one destruction path answer with an uncaught fatal instead of the 404 they were written to return.

The fix

MagicMapper::find(string|int $identifier, ...) is the method meant here. Its own docblock says the identifier may be an "ID, UUID, slug, or URI", it returns ObjectEntity, and it throws DoesNotExistException when absent — which is precisely what these call sites expect and already catch.

Also corrected a @throws in ObjectService::rejectIfTransferred that named \OCP\AppFramework\Http\ContentSecurityPolicy, a CSP class rather than an exception. The method throws DoesNotExistException.

Verification

vendor/bin/psalm 5.26.1 on PHP 8.3: errors with the baseline emptied went 180 -> 173, regenerated baseline green. PHPUnit not run locally (needs the server bootstrap).

[github-actions]

Quality Report — ConductionNL/openregister @ 0f040db

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-specs		✅
test-l10n		✅
test-l10n-parity		✅
format		✅
check-schema-l10n		✅
check-l10n-js		✅
composer			✅	✅ 174/174
npm			✅	✅ 543/543
app:check-code	⏭️
info.xml	✅
REUSE	❌
PHPUnit					❌
Newman					✅
Playwright					⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development
Hydra gates					✅

---

Quality workflow — 2026-08-31 17:27 UTC

Download the full PDF report from the workflow artifacts.

[github-actions]

Quality Report — ConductionNL/openregister @ 8066cb9

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-specs		✅
test-l10n		✅
test-l10n-parity		✅
format		✅
check-schema-l10n		✅
check-l10n-js		✅
composer			✅	✅ 174/174
npm			✅	✅ 543/543
app:check-code	⏭️
info.xml	✅
REUSE	❌
PHPUnit					✅
Newman					✅
Playwright					⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development
Hydra gates					✅

---

Quality workflow — 2026-08-31 17:38 UTC

Download the full PDF report from the workflow artifacts.