docs: show how to mount GitHub App private key in Kubernetes - #183
Conversation
BATON_APP_PRIVATEKEY_PATH was documented without showing how the key file actually gets onto the container filesystem. Add a Secret + volume mount example, consistent with the pattern already used in other connector docs.
| volumes: | ||
| - name: github-app-key | ||
| secret: | ||
| secretName: baton-github-app-key |
There was a problem hiding this comment.
🟡 Suggestion: A GitHub App private key mounted from a Secret gets Kubernetes' default file mode of 0644, making it readable by any non-root process in the container. Since this is credential material, consider setting defaultMode: 0400 in the example so users copying this manifest get a tighter default.
| volumes: | |
| - name: github-app-key | |
| secret: | |
| secretName: baton-github-app-key | |
| volumes: | |
| - name: github-app-key | |
| secret: | |
| secretName: baton-github-app-key | |
| defaultMode: 0400 |
Connector PR Review: docs: show how to mount GitHub App private key in KubernetesBlocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0 Review SummaryScanned the full PR diff for security and correctness. This is a docs-only change to Security IssuesNone found. Correctness IssuesNone found. Suggestions
Prompt for AI agents |
Summary
BATON_APP_PRIVATEKEY_PATHbut never shows how the key file gets onto the connector container's filesystem at that path.volumeMounts/volumesexample in the Deployment manifest.BATON_APP_PRIVATEKEY_PATH— theBATON_APP_PRIVATEKEY(raw PEM) alternative doesn't need a volume mount.Test plan