fix(codex): route busy steer to active turn - #4
Merged
Merged
Conversation
LuneZ99
marked this pull request as ready for review
August 11, 2026 08:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AIAgent.steer()through Codex app-server's nativeturn/steerRPC while a Codex turn is active.turnId; rejection falls back to the Gateway FIFO queue.AIAgent.steer()→request_steer()link and malformed acknowledgements.Root cause
Gateway
busy_input_mode=steercallsrunning_agent.steer(). The Codex-native call was only wired intoredirect(), sosteer()stored text in Hermes_pending_steer. Codex app-server owns its internal tool loop, meaning Hermes never reached the tool-result drain point. Gateway nevertheless reported success and skipped queueing the message.NousResearch/hermes-agent
mainat9829746dstill has this routing gap. The strict acknowledgement change follows the complementary upstream PR NousResearch#82492.Impact
Busy follow-ups now reach the active Codex turn. If there is no active turn, the RPC is rejected, times out, or returns an uncorrelated response, Hermes reports failure so Gateway queues the original message instead of dropping it.
Checks
uv run ruff check .— passedgit diff --check— passedscripts/run_tests.sh -j 16; stopped after unrelated existing failures in LSP subprocess guarding, missing optional Anthropic SDK tests, and credential-pool routing.Draft only: merge after the trading session and complete the Harness image verification before production rollout.