docs(node): say what control.wallet.peak's synced flag actually measures - #78
Draft
MichaelTaylor3d wants to merge 1 commit into
Draft
docs(node): say what control.wallet.peak's synced flag actually measures#78MichaelTaylor3d wants to merge 1 commit into
MichaelTaylor3d wants to merge 1 commit into
Conversation
…sures The flag is measured against the heights this node's Chia peers report, not against whether a first sync once finished, so a node that has fallen behind now answers `synced: false` while still serving its real height. The table said 'fully synced', which reads as an outage and would have a person discard a perfectly usable height. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coherence half of DIG-Network/dig-node#295 (dig-node#293).
control.wallet.peakcomputed itssyncedflag from theinitial_sync_completelatch, so a node hundreds of blocks behind reportedsynced: true. dig-node#295 replaces that with the same measured predicate the balance read uses. These docs described the old behaviour as 'whether this node's own copy of the chain is fully synced', which after the fix reads as an outage rather than as staleness — and would have a person discard a height that is real, dated, and still the best bound they have.Version 0.16.1 -> 0.16.2 (patch; documentation only).
Parent: https://github.com/DIG-Network/dig_ecosystem/issues/2760