🐛 [devext] support v7 session cookie and expose anonymous ID / account context - #4960
🐛 [devext] support v7 session cookie and expose anonymous ID / account context#4960mormubis wants to merge 7 commits into
Conversation
| .find(([cookieName]) => cookieName === name) | ||
| ?.[1] | ||
| } | ||
| const isV7 = window.DD_RUM?.version?.startsWith('7') || window.DD_LOGS?.version?.startsWith('7') |
There was a problem hiding this comment.
If the SDK hasn't initialized yet when the extension first reads, version is undefined and isV7 is false, so it falls back to _dd_s. On the next poll (once the SDK is up) it corrects itself. Not a real issue in practice but worth knowing.
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 248ec33 | Docs | View more details | Give us feedback! |
5eb1c53 to
8af253c
Compare
Bundles Sizes Evolution
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8af253ce64
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .find(([cookieName]) => cookieName === name) | ||
| ?.[1] |
There was a problem hiding this comment.
issue: When multiple _dd_s_v2 cookies are visible, such as after changing trackSessionAcrossSubdomains or partitioned-cookie settings, this returns the first value regardless of its c marker. The v7 SDK deliberately selects the cookie whose marker matches its current cookie options in sessionInCookie.ts, so the extension can display and link to a stale or unrelated session instead of the one the SDK is using.
Useful? React with 👍 / 👎.
| ` | ||
| document.cookie = '_dd_s=isExpired=1; expires=${expires}; path=/' | ||
| if (document.cookie.includes('_dd_s_v2=')) { | ||
| document.cookie = '_dd_s_v2=isExpired=1; expires=${expires}; path=/' |
There was a problem hiding this comment.
issue: For v7 applications using trackSessionAcrossSubdomains or usePartitionedCrossSiteSessionCookie, this assignment omits the original Domain or Partitioned attributes and therefore creates or updates a different cookie rather than the SDK's active _dd_s_v2. Because the SDK continues selecting the original cookie by its c marker, clicking “End current session” does not actually end that session; use the SDK configuration to write the expiration with matching cookie attributes.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This already exists on main for _dd_s too, not something this PR introduced. Goes back to #2673. I'd rather fix both cookie names together in a follow-up since it reuses the sdkConfig lookup from the marker matching fix.
| internalContext: window.DD_RUM?.getInternalContext?.(), | ||
| globalContext: window.DD_RUM?.getGlobalContext?.(), | ||
| user: window.DD_RUM?.getUser?.(), | ||
| account: window.DD_RUM?.getAccount?.(), |
There was a problem hiding this comment.
issue: Opening the Infos tab now invokes RUM's instrumented getAccount() method every two seconds. That method records the get-account telemetry usage feature, so merely inspecting a page marks the API as customer-used even when the application never calls it, contaminating API-adoption measurements; retrieve the account through a non-instrumented inspection path instead.
AGENTS.md reference: AGENTS.md:L120-L120
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This already applies to getUser() and getGlobalContext() on main, not just getAccount() added here. getInitConfiguration() and getInternalContext() don't carry user/account data, so there's no non-instrumented path to read it today. Would need a follow-up, possibly on the SDK side, to add one.
The SDK version string cannot identify which cookie name is active: local dev builds always report 'dev' regardless of which major is checked out, so a v6 and a v7 dev build are indistinguishable. Read both names and keep whichever holds the more recently created valid session instead. Also apply c marker matching to _dd_s, not just _dd_s_v2, since v6 with betaEncodeCookieOptions could also write duplicates under that name.
1 participant
Motivation
SDK v7 renamed the session cookie from
_dd_sto_dd_s_v2, so the extension was showing empty session data for any v7 app. v7 also added anaid(anonymous ID) field in the cookie and agetAccount()API that the extension wasn't exposing. Jira: RUM-17172.Changes
In
useSdkInfos.ts, cookie reading no longer tries to detect which SDK major is running. The version string can't do that reliably: local dev builds always reportversion: "dev"regardless of which major is checked out, so a v6 dev build and a v7 dev build look identical. Instead, it reads both_dd_sand_dd_s_v2, and keeps whichever holds the more recently created valid session, since only an actively running SDK writes fresh data under its own cookie name.Both cookie names can also have duplicates under the same name (e.g. after changing
trackSessionAcrossSubdomainsorusePartitionedCrossSiteSessionCookie, or with v6'sbetaEncodeCookieOptions). The SDK picks the right one by matching acmarker encoded in the cookie value against its current config.findMatchingCookieValue()replicates that matching for both cookie names, so the extension doesn't just grab the first duplicate.The
aidcookie field is mapped toanonymousIdfor readability. AddedgetAccount()calls for both RUM and Logs.In
infosTab.tsx, anonymous ID shows under the cookie section, account under RUM and Logs.endSession()also expires_dd_s_v2, but only if it already exists — unconditionally writing it on a v6 page would create a phantom cookie that shadows the real v6 session on next load.Test instructions
yarn dev, openhttp://localhost:8080, open the Infos tab. Session data should show, including the anonymous ID.DD_RUM.setAccount({ id: 'test' })in the console. Account should appear under RUM._dd_s_v2should be expired in Application → Cookies, and reloading starts a new session._dd_s(e.g.document.cookie = '_dd_s=id=v6&created=' + Date.now() + '&expire=9999999999999; path=/') while a stale_dd_s_v2is still present. The Infos tab should now read from_dd_s, since it holds the more recently created session._dd_s_v2cookies with differentcvalues by hand (or reuse ones left over from changingtrackSessionAcrossSubdomainsbetween reloads) and confirm the extension shows the one matching the SDK's current config, not just the first one found.Checklist