-
Notifications
You must be signed in to change notification settings - Fork 192
✨ enable partial view updates by default for CDN users without a proxy #5000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mormubis
wants to merge
9
commits into
main
Choose a base branch
from
adlrb/pvu-enable-by-default
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+89
−2
Draft
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
53b06dc
♻️ expose the build-time SDK setup as a mockable accessor
mormubis 5eb08c1
✨ enable partial view updates by default for CDN users without a proxy
mormubis b470521
♻️ read the build-env setup locally instead of via a shared accessor
mormubis 0ab58cf
🎨 type the build-env setup declare as the union it actually is
mormubis 6baf5d4
🧹 drop the schema comment, the rationale lives in the PR
mormubis 97d5647
♻️ drop the redundant Omit entry for betaEnableViewUpdates
mormubis 02a03c4
📝 note that the CDN check is temporary
mormubis 942876b
⏪️ keep the telemetry declare as string
mormubis f99fe23
⏪️ declare the build-env setup as string, like every other build-env …
mormubis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the
default. Withdefault: falseyou can't tell if the user passedfalseor didn't pass anything, both end up asfalseafter validation. So the default is resolved invalidateAndBuildRumConfigurationinstead.