Migrate SAST config to code-security.datadog.yaml - #210
Conversation
Renames static-analysis.datadog.yaml (legacy schema, wrong filename) to code-security.datadog.yaml on the current schema-version v1.0 format, and fixes an indentation bug that orphaned the no-console rule config so it never actually applied.
There was a problem hiding this comment.
PR Review — Score: 4.9 / 5
This is a well-scoped SAST configuration migration: the legacy static-analysis.datadog.yaml is replaced with the current code-security.datadog.yaml v1.0 schema, the typescript-best-practices indentation bug is fixed so no-console ignore paths are actually nested under that ruleset, and use-default-rulesets: false preserves the prior “only these two rulesets” behavior. I would approve.
Why 4.9: The YAML structure is valid (verified via PyYAML), rule and global ignore paths match the old file, and the PR description accurately explains the schema and behavioral intent. No SDK runtime, API, or test code is touched.
Why not 5: The remaining gap is operational confirmation that Datadog’s scanner discovers code-security.datadog.yaml on the next repo scan (already noted in the test plan). That is outside what we can verify from the diff alone.
CI was still running on some dd-gitlab/* jobs when this review was posted; that is noted for context only and is not a review finding.
Sent by Cursor Automation: electron-sdk reviews


Summary
static-analysis.datadog.yaml(legacy schema, and mismatched filename/extension for that schema) tocode-security.datadog.yamlon the currentschema-version: v1.0formattypescript-best-practices'srules:key was a sibling of the ruleset entry instead of nested under it, so theno-consoleignore-paths never actually applieduse-default-rulesets: falseis set explicitly to preserve the legacy behavior, where the listed rulesets were the complete set run (no implicit defaults)Test plan
no-consoleandno-newrule-configs both correctly nested)