Skip to content

Migrate SAST config to code-security.datadog.yaml - #210

Open
kikoveiga wants to merge 1 commit into
mainfrom
francisco.veiga/migrate-code-security-sast-config
Open

Migrate SAST config to code-security.datadog.yaml#210
kikoveiga wants to merge 1 commit into
mainfrom
francisco.veiga/migrate-code-security-sast-config

Conversation

@kikoveiga

Copy link
Copy Markdown
Contributor

Summary

  • Rename static-analysis.datadog.yaml (legacy schema, and mismatched filename/extension for that schema) to code-security.datadog.yaml on the current schema-version: v1.0 format
  • Fix an indentation bug in the old file where typescript-best-practices's rules: key was a sibling of the ruleset entry instead of nested under it, so the no-console ignore-paths never actually applied
  • use-default-rulesets: false is set explicitly to preserve the legacy behavior, where the listed rulesets were the complete set run (no implicit defaults)

Test plan

  • Parsed the new file with PyYAML to confirm the nested structure resolves as expected (no-console and no-new rule-configs both correctly nested)
  • Confirm the ruleset actually picks up the file once Datadog next scans this repo

Renames static-analysis.datadog.yaml (legacy schema, wrong filename)
to code-security.datadog.yaml on the current schema-version v1.0
format, and fixes an indentation bug that orphaned the no-console
rule config so it never actually applied.
@kikoveiga
kikoveiga requested a review from a team as a code owner August 27, 2026 14:53

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review — Score: 4.9 / 5

This is a well-scoped SAST configuration migration: the legacy static-analysis.datadog.yaml is replaced with the current code-security.datadog.yaml v1.0 schema, the typescript-best-practices indentation bug is fixed so no-console ignore paths are actually nested under that ruleset, and use-default-rulesets: false preserves the prior “only these two rulesets” behavior. I would approve.

Why 4.9: The YAML structure is valid (verified via PyYAML), rule and global ignore paths match the old file, and the PR description accurately explains the schema and behavioral intent. No SDK runtime, API, or test code is touched.

Why not 5: The remaining gap is operational confirmation that Datadog’s scanner discovers code-security.datadog.yaml on the next repo scan (already noted in the test plan). That is outside what we can verify from the diff alone.


CI was still running on some dd-gitlab/* jobs when this review was posted; that is noted for context only and is not a review finding.

Open in Web View Automation 

Sent by Cursor Automation: electron-sdk reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant