Skip to content

fix(build): build script change detection #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paullegranddc wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −6
Open

fix(build): build script change detection #2467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libdd-ffe-ffi/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ extern crate build_common;
use build_common::generate_and_configure_header;

fn main() {
println!("cargo:rerun-if-changed=src/*");
println!("cargo:rerun-if-changed=src");
println!("cargo:rerun-if-changed=cbindgen.toml");
println!("cargo:rerun-if-changed=build.rs");
let header_name = "ffe.h";
Expand Down
2 changes: 1 addition & 1 deletion libdd-profiling-heap-gotter-ffi/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ extern crate build_common;
use build_common::generate_and_configure_header;

fn main() {
println!("cargo:rerun-if-changed=src/*");
println!("cargo:rerun-if-changed=src");
println!("cargo:rerun-if-changed=cbindgen.toml");
println!("cargo:rerun-if-changed=build.rs");
generate_and_configure_header("heap_gotter.h");
Expand Down
6 changes: 2 additions & 4 deletions libdd-trace-protobuf/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ use {

// to re-generate protobuf structs, run cargo build --features generate-protobuf
fn main() -> Result<()> {
println!("cargo:rerun-if-changed=build.rs");
#[cfg(feature = "generate-protobuf")]
{
// protoc is required to compile proto files. This uses protobuf_src to compile protoc
Expand All @@ -19,10 +20,6 @@ fn main() -> Result<()> {
// compiles the .proto files into rust structs
generate_protobuf();
}
#[cfg(not(feature = "generate-protobuf"))]
{
println!("cargo:rerun-if-changed=build.rs");
}

Ok(())
}
Expand Down Expand Up @@ -354,6 +351,7 @@ fn generate_protobuf() {

config.include_file("_includes.rs");

println!("cargo:rerun-if-changed=src/pb");
config
.compile_protos(
&[
Expand Down
Loading