pup: enable OAuth for DDSQL editor commands - #756
Draft
srosenthal-dd wants to merge 2 commits into
Draft
Conversation
Remove 3 dsql-editor tool endpoints from OAUTH_EXCLUDED_ENDPOINTS so raw_get/raw_post send the OAuth bearer token for ddsql::spec, ddsql::schema_tables, and ddsql::schema_columns commands. Depends on server-side PR: dd-source#66615
…th-ddsql-editor # Conflicts: # src/raw_client.rs
platinummonkey
pushed a commit
that referenced
this pull request
Aug 27, 2026
…nd CCM Remove 32 entries from OAUTH_EXCLUDED_ENDPOINTS for endpoint groups whose server-side routes already accept OAuth: - Fleet Automation (15): v2 routes already have ValidOAuthAccessToken - Cost/Billing (3): server already accepts OAuth (DAL-959) - Cloud Cost Management config (14): server already accepts OAuth (DAL-959) Also remove the brittle OAUTH_EXCLUDED_ENDPOINTS count assertion (test_oauth_excluded_count) which was prone to merge conflicts and tested no actual behavior. Update test_requires_api_key_fallback_fleet to test_no_fallback_for_fleet, and switch the test_other_oauth_excluded_endpoints example from Fleet to Profiling (which remains excluded). Remaining excluded entries (8): DDSQL editor (3, handled by #756), Profiling (4, no OAuth scope), Events intake (1, SDK codegen issue).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove 3 dsql-editor tool endpoints from
OAUTH_EXCLUDED_ENDPOINTSsoraw_get/raw_postsend the OAuth bearer token forddsql::spec,ddsql::schema_tables, andddsql::schema_columnscommands.Server-side dependency
Depends on dd-source#66615 which adds
ValidOAuthAccessTokento the 3 ddsql-editor routes. Do not merge until that PR is merged.Changes
src/raw_client.rs: Removed 3 dsql-editor entries fromOAUTH_EXCLUDED_ENDPOINTS(46 -> 43), updated count test, removed obsolete ddsql-editor test