fix(nodejs): upgrade Bun to 1.4.0 - #7615
Conversation
bm1549
added
build-nodejs-base-images
ai-generated
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: be5f9f7 | Docs | View more details | Give us feedback! |
Keep only the mirror_images.yaml regeneration and Bun/base-v4 image changes; drop the header-preservation logic and its coverage as out of scope for this fix.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be5f9f7809
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - "datadog/system-tests:express4-typescript.base-v1" | ||
| - "datadog/system-tests:express4-typescript.base-v2" | ||
| - "datadog/system-tests:express4-typescript.base-v3" | ||
| - "datadog/system-tests:express4-typescript.base-v4" |
There was a problem hiding this comment.
The five new base-v4 images are added only to mirror_images.yaml; mirror_images.lock.yaml still contains only their base-v3 entries. In the inspected .gitlab-ci.yml flow, the mirror_images job mirrors exclusively from the committed lock file (lines 441–443), so it will never populate these new bases before the dependent Node.js builds run with USE_IMAGE_MIRROR=1. Those builds can consequently bypass the intended internal mirror and fall through to unauthenticated Docker Hub pulls, which may fail under rate limiting. After publishing the v4 images, regenerate and commit the lock file as required by this file's header.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Silly codex, I already added this in the PR description!
Before merge, R&P needs to publish the five base-v4 images and regenerate mirror_images.lock.yaml from their public digests.
ajgajg1134
left a comment
ajgajg1134
left a comment
There was a problem hiding this comment.
seems like an appropriate and good change to me. Only thing is to make sure the images are published before merging as far as I can tell
2 participants
Motivation
Bun 1.3.13 can reject a valid streamed tarball when the first HTTP body chunk is too small. That can break dependency installation while building the Next.js weblog. Bun 1.4.0 includes oven-sh/bun#34861, which fixes the stream handling.
Changes
base-v3tobase-v4.base-v4images tomirror_images.yaml.Tested with:
./build.sh nodejs -w nextjsBefore merge, R&P needs to publish the five
base-v4images and regeneratemirror_images.lock.yamlfrom their public digests.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present