Enable mypy on utils/onboarding/.* - #7637
Conversation
|
|
| else: | ||
| logger.info(f"Making a request to weblog {weblog_url}") | ||
| request_uuids.append(make_get_request(weblog_url)) | ||
| warmup_weblog(f"http://{vm_ip}:{vm_port}/") |
There was a problem hiding this comment.
Need a review here. warmup_weblog always returns None, so this Pr don't change the logic.
Though, the deleted code makes me thinks it's an error, and a bit of logic has been lost down the road.
There was a problem hiding this comment.
No, this piece is important is for very concrete case. We should not remove it
There was a problem hiding this comment.
Yes, that's my question. Right now, this code can't be reached, as warmup_weblog always returns None. That's why Claude removed it.
There was a problem hiding this comment.
the easy way is to test it. I'll launch the full pipeline
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🔗 Commit SHA: af27e68 | Docs | View more details | Give us feedback! |
| else: | ||
| logger.info(f"Making a request to weblog {weblog_url}") | ||
| request_uuids.append(make_get_request(weblog_url)) | ||
| warmup_weblog(f"http://{vm_ip}:{vm_port}/") |
There was a problem hiding this comment.
No, this piece is important is for very concrete case. We should not remove it
2 participants
Motivation
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present