Skip to content

test(otel): parametric coverage for OTEL_SDK_DISABLED - #7655

Draft
MilanGarnier wants to merge 1 commit into
mainfrom
milan.garnier/test-otel-sdk-disabled
Draft

test(otel): parametric coverage for OTEL_SDK_DISABLED#7655
MilanGarnier wants to merge 1 commit into
mainfrom
milan.garnier/test-otel-sdk-disabled

Conversation

@MilanGarnier

@MilanGarnier MilanGarnier commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Motivation

Add specification-based parametric coverage for OTEL_SDK_DISABLED.

Tracks APMAPI-2400.

Changes

  • Test the stable true and false values and the specification default.
  • Preserve the existing Datadog configuration precedence coverage.
  • Move variable-specific coverage into tests/parametric/otel_env_vars/.
  • Declare support in every tracer manifest from the configuration registry.
  • Add a standalone skill and ticket map for future OTEL variable tests:

    Add or refine parametric coverage for an OpenTelemetry OTEL_* environment
    variable, including value matrices, defaults, registry-based manifest
    declarations, and migration of existing variable-specific tests.

Validation

  • Collected all four tests successfully.
  • Ran the full test class against Node.js 6.13: 2 passed, 2 expected failures.
  • Passed focused Ruff and manifest validation.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from
      R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🚿 #apm-shared-testing 🚿

Reviewer checklist

  • Anything but tests/ or manifests/ is modified? I have the approval
    from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

.agents/skills/test-otel-env-var-parametrically/SKILL.md                @DataDog/system-tests-core
.agents/skills/test-otel-env-var-parametrically/references/otel-environment-variable-sections.csv  @DataDog/system-tests-core
tests/parametric/otel_env_vars/__init__.py                              @DataDog/system-tests-core @DataDog/apm-sdk-capabilities
tests/parametric/otel_env_vars/test_otel_sdk_disabled.py                @DataDog/system-tests-core @DataDog/apm-sdk-capabilities
manifests/cpp.yml                                                       @DataDog/system-tests-reviewers
manifests/dotnet.yml                                                    @DataDog/system-tests-reviewers
manifests/golang.yml                                                    @DataDog/system-tests-reviewers
manifests/java.yml                                                      @DataDog/system-tests-reviewers
manifests/nodejs.yml                                                    @DataDog/system-tests-reviewers
manifests/php.yml                                                       @DataDog/system-tests-reviewers
manifests/python.yml                                                    @DataDog/system-tests-reviewers
manifests/ruby.yml                                                      @DataDog/system-tests-reviewers
manifests/rust.yml                                                      @DataDog/system-tests-reviewers
tests/parametric/test_otel_env_vars.py                                  @DataDog/system-tests-core @DataDog/apm-sdk-capabilities
tests/test_the_test/scenarios.json                                      @DataDog/system-tests-core

@MilanGarnier MilanGarnier changed the title milan.garnier/test otel sdk disabled test(otel): cover OTEL_SDK_DISABLED parametrically Sep 4, 2026
@datadog-official

datadog-official Bot commented Sep 4, 2026

Copy link
Copy Markdown

Pipelines  Tests

Unblock PR with BitsAI

⚠️ Warnings

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 67 Pipeline jobs failed

DataDog/system-tests | K8S_LIB_INJECTION_APPSEC_DISABLED: [dd-lib-ruby-init-test-rails, ${PRIVATE_DOCKER_REGISTRY}/system-tests/dd-lib-ruby-init-test-rails, 235494822917.dkr.ecr.us-east-1.amazonaws.com/ssi/cluster-agent:7.82.3, 235494822917.dkr.ecr.us-east-1.amazonaws.com/ssi/apm-inject:latest_snapshot, 3.241.0, 235494822917.dkr.ecr.us-east-1.amazonaws.com/ssi/dd-lib-ruby-init:latest_snapshot] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/system-tests | K8S_LIB_INJECTION: [dd-lib-ruby-init-test-rails, ${PRIVATE_DOCKER_REGISTRY}/system-tests/dd-lib-ruby-init-test-rails, 235494822917.dkr.ecr.us-east-1.amazonaws.com/ssi/cluster-agent:7.82.3, 235494822917.dkr.ecr.us-east-1.amazonaws.com/ssi/apm-inject:latest, 3.241.0, 235494822917.dkr.ecr.us-east-1.amazonaws.com/ssi/dd-lib-ruby-init:latest] — 🔄 Retry may pass, looks flaky

View more details · View in GitLab

DataDog/system-tests | K8S_LIB_INJECTION: [dd-lib-ruby-init-test-rails, ${PRIVATE_DOCKER_REGISTRY}/system-tests/dd-lib-ruby-init-test-rails, 235494822917.dkr.ecr.us-east-1.amazonaws.com/ssi/cluster-agent:7.82.3, 235494822917.dkr.ecr.us-east-1.amazonaws.com/ssi/apm-inject:latest_snapshot, 3.241.0, 235494822917.dkr.ecr.us-east-1.amazonaws.com/ssi/dd-lib-ruby-init:latest_snapshot] — 🔄 Retry may pass, looks flaky

View more details · View in GitLab

View all 67 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6797bc5 | Docs | View more details | Give us feedback!

@MilanGarnier MilanGarnier changed the title test(otel): cover OTEL_SDK_DISABLED parametrically test(otel): parametric coverage for OTEL_SDK_DISABLED Sep 4, 2026
Base automatically changed from milan.garnier/otel-environment-variable-feature-tags to main September 4, 2026 16:24
@MilanGarnier
MilanGarnier force-pushed the milan.garnier/test-otel-sdk-disabled branch from ebb1ae7 to 6797bc5 Compare September 4, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant