Skip to content

refactor(model): unify PropertyChangeEvent check via matches() - #265

Merged
funa-tk merged 1 commit into
DeNA:masterfrom
toku-sa-n:refactor/unify-property-change-matches
Sep 1, 2026
Merged

refactor(model): unify PropertyChangeEvent check via matches()#265
funa-tk merged 1 commit into
DeNA:masterfrom
toku-sa-n:refactor/unify-property-change-matches

Conversation

@toku-sa-n

Copy link
Copy Markdown
Contributor

.toString()による比較ではなく、.matches()を使用して簡略にしました。

Replace hand-written toString().equals(evt.getPropertyName()) in
Packets.propertyChange with PropertyChangeEventType.matches(evt) for
consistency with the rest of the codebase.

Co-authored-by: Cursor <cursoragent@cursor.com>
@toku-sa-n
toku-sa-n force-pushed the refactor/unify-property-change-matches branch from 10d6f0c to 0b435b9 Compare July 10, 2026 11:36

@funa-tk funa-tk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです

@funa-tk
funa-tk merged commit cab44e8 into DeNA:master Sep 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants