LuckPerms Command - #456
Open
MC-Samuel wants to merge 1 commit into
Open
Conversation
davight
reviewed
Aug 11, 2026
|
|
||
| public LuckPermsCommand() { | ||
| setName("luckperms"); | ||
| setSyntax("luckperms [{set}/unset] [user:<player>/group:<group>] [permission] (state:{true}/false) (duration:<duration>) (contexts:<map>)"); |
Contributor
There was a problem hiding this comment.
We could probably make this take users and groups as ListTag rather than only one value.
Which would allow to do easier things like this rather than foreach:
- luckperms set users:<server.online_players> bonus duration:2h
davight
reviewed
Aug 11, 2026
| } | ||
| Node node = nodeBuilder.build(); | ||
| switch (action) { | ||
| case SET: { |
Contributor
There was a problem hiding this comment.
we could use that new switch without needing to break it
davight
reviewed
Aug 11, 2026
Comment on lines
+172
to
+188
| for (PermissionNode node : object.getGroup().getNodes(NodeType.PERMISSION)) { | ||
| if (node.getKey().equalsIgnoreCase(permission)) { | ||
| bestNode = node; | ||
| break; | ||
| } | ||
| else if (node.isWildcard() && node.getWildcardLevel().isPresent()) { | ||
| int size = node.getKey().substring(0, node.getKey().length() - 1).length(); | ||
| if (permission.length() < size || !permission.substring(0, size).equalsIgnoreCase(node.getKey().substring(0, size))) { | ||
| continue; | ||
| } | ||
| if (node.getWildcardLevel().getAsInt() > wildcardLevel) { | ||
| bestNode = node; | ||
| wildcardLevel = node.getWildcardLevel().getAsInt(); | ||
| } | ||
| } | ||
| } | ||
| return bestNode != null ? new DurationTag(bestNode.getExpiryDuration() != null ? (int) bestNode.getExpiryDuration().getSeconds() : 0) : null; |
Contributor
There was a problem hiding this comment.
could probably extract this to a method since its the same for both tags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the command gives the ability to set temporary permissions, having a tag to get their duration seems like it would be helpful to those using it.