Remove deprecated features esmvaltool config get_config_user, esmvaltool config get_config_developer, esmvalcore.local.DataSource

[schlunma]

Description

This PRs removes some of the deprecated features that are scheduled for removal in v2.16.0. There are a lot of them, so I thought its best to do this piece by piece.

Backwards-incompatible change #

This PR removes deprecated features that are scheduled for removal in v2.16.0.

esmvaltool config get_config_user

Deprecated in #2765. Use esmvaltool config copy instead.

esmvaltool config get_config_developer

The config-developer.yml file has been deprecated in #2946. The corresponding option are now configured in ESMValCore's configuration. These configuration files can be copied via esmvaltool config copy instead.

esmvalcore.local.DataSource

Deprecated in #2911. Use esmvalcore.io.local.LocalDataSource instead.

---

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🧪 The new functionality is relevant and scientifically sound
• 🛠 This pull request has a descriptive title and labels
• 🛠 Code is written according to the code quality guidelines
• 🧪 and 🛠 Documentation is available
• 🛠 Unit tests have been added
• 🛠 Changes are backward compatible
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 The list of authors is up to date
• 🛠 All checks below this pull request were successful

---

To help with the number pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.45%. Comparing base (936450c) to head (870519f).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3210      +/-   ##
==========================================
- Coverage   96.50%   96.45%   -0.06%     
==========================================
  Files         281      281              
  Lines       16360    16317      -43     
==========================================
- Hits        15789    15739      -50     
- Misses        571      578       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bouweandela]

Looks good, though esmvalcore.local.DataSource seems a bit unrelated to the command line options that are removed in this pull request, so it may look nicer in the changelog to make it two separate PRs.

[schlunma]

Yeah, agreed. Originally, I wanted to handle all cases in a single PR, but quickly realized that there are way too many. If you prefer, I can open a separate PR, but we could always manually adapt the changelog (we do this for the backwards-incompatible changes anyway).

[schlunma]

Merging this now to allow review of #3211.