Add missing testIDs for maestro selectors - #6180
Merged
Merged
Conversation
j0ntz
marked this pull request as ready for review
August 28, 2026 04:18
j0ntz
force-pushed
the
jon/1216079900947419
branch
from
August 28, 2026 04:18
62e9fc6 to
e51ec8e
Compare
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
j0ntz
force-pushed
the
jon/1216079900947419
branch
from
August 28, 2026 23:28
e51ec8e to
06c1261
Compare
j0ntz
force-pushed
the
jon/1216079900947419
branch
from
August 28, 2026 23:51
06c1261 to
996ae15
Compare
j0ntz
enabled auto-merge
August 28, 2026 23:51
Contributor
Author
|
Force merging - test selectors only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Asana: https://app.asana.com/0/1215088146871429/1216079900947419
Test-infrastructure only. The diff adds two
testIDprops and changes nothing else, so no rendering or behavior moves.Driving the Exchange scene from a maestro flow had no way to reach the source and receiving wallet pills on
SwapCreateScene: they arePillButtons that never received thetestIDthe component already accepts, so a flow could only anchor on their accessibility text.SwapInputtakes awalletPillTestIDand forwards it to itsPillButton.SwapCreateScenenames the two pillsswapFromWalletPillandswapToWalletPill.The wallet picker rows are no longer part of this PR.
develophas since added its ownwalletListRow_<name>_<code>selectors toWalletListCurrencyRow, which cover the same need, so the rebase dropped this branch's redundant (and differently named) row testID.Note
Low Risk
Test-only props wired to existing
PillButtontestIDsupport; no production logic or layout changes.Overview
Maestro flows can now target the swap scene’s source and destination wallet selectors without relying on accessibility labels.
SwapInputaccepts an optionalwalletPillTestIDand passes it to the headerPillButtonastestID.SwapCreateScenesetsswapFromWalletPillandswapToWalletPillon the paying and receiving inputs. No user-visible UI or behavior changes.Reviewed by Cursor Bugbot for commit 996ae15. Bugbot is set up for automated code reviews on this repo. Configure here.