Skip to content

Add missing testIDs for maestro selectors - #6180

Merged
j0ntz merged 1 commit into
developfrom
jon/1216079900947419
Aug 29, 2026
Merged

Add missing testIDs for maestro selectors#6180
j0ntz merged 1 commit into
developfrom
jon/1216079900947419

Conversation

@j0ntz

@j0ntz j0ntz commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Description

Asana: https://app.asana.com/0/1215088146871429/1216079900947419

Test-infrastructure only. The diff adds two testID props and changes nothing else, so no rendering or behavior moves.

Driving the Exchange scene from a maestro flow had no way to reach the source and receiving wallet pills on SwapCreateScene: they are PillButtons that never received the testID the component already accepts, so a flow could only anchor on their accessibility text.

  • SwapInput takes a walletPillTestID and forwards it to its PillButton.
  • SwapCreateScene names the two pills swapFromWalletPill and swapToWalletPill.

The wallet picker rows are no longer part of this PR. develop has since added its own walletListRow_<name>_<code> selectors to WalletListCurrencyRow, which cover the same need, so the rebase dropped this branch's redundant (and differently named) row testID.


Note

Low Risk
Test-only props wired to existing PillButton testID support; no production logic or layout changes.

Overview
Maestro flows can now target the swap scene’s source and destination wallet selectors without relying on accessibility labels.

SwapInput accepts an optional walletPillTestID and passes it to the header PillButton as testID. SwapCreateScene sets swapFromWalletPill and swapToWalletPill on the paying and receiving inputs. No user-visible UI or behavior changes.

Reviewed by Cursor Bugbot for commit 996ae15. Bugbot is set up for automated code reviews on this repo. Configure here.

@j0ntz
j0ntz marked this pull request as ready for review August 28, 2026 04:18
@j0ntz
j0ntz force-pushed the jon/1216079900947419 branch from 62e9fc6 to e51ec8e Compare August 28, 2026 04:18
@cursor

cursor Bot commented Aug 28, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@j0ntz
j0ntz force-pushed the jon/1216079900947419 branch from e51ec8e to 06c1261 Compare August 28, 2026 23:28
@j0ntz
j0ntz force-pushed the jon/1216079900947419 branch from 06c1261 to 996ae15 Compare August 28, 2026 23:51
@j0ntz
j0ntz enabled auto-merge August 28, 2026 23:51
@j0ntz

j0ntz commented Aug 29, 2026

Copy link
Copy Markdown
Contributor Author

Force merging - test selectors only.

@j0ntz
j0ntz disabled auto-merge August 29, 2026 00:10
@j0ntz
j0ntz merged commit 359eac1 into develop Aug 29, 2026
7 checks passed
@j0ntz
j0ntz deleted the jon/1216079900947419 branch August 29, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant