make: skip extract-bolt-csv if bolts are absent - #9393
Open
daywalker90 wants to merge 1 commit into
Open
Conversation
daywalker90
force-pushed
the
skip-check-wire-format
branch
from
August 7, 2026 14:44
2e9d5d7 to
825c5d7
Compare
daywalker90
changed the title
`check-source` -> `check-wire-format` unconditionally ran `extract-bolt-csv`, which failed when `../bolts` was not checked out: ``` /bin/sh: 1: .tmp.lightningrfc/tools/extract-formats.py: not found make: *** [wire/Makefile:54: wire/peer_wire.csv.raw] Error 127 ``` Skip it via `bolt-precheck` when `.tmp.lightningrfc` is missing, matching the `bolt-check` pattern. Changelog-None
daywalker90
force-pushed
the
skip-check-wire-format
branch
from
August 7, 2026 14:45
825c5d7 to
ba2a0cb
Compare
daywalker90
added
the
Status::Ready for Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-source->check-wire-formatunconditionally ranextract-bolt-csv, which failed when../boltswas not checked out:Skip it via
bolt-precheckwhen.tmp.lightningrfcis missing,matching the
bolt-checkpattern.