common: reject banned Unicode categories in protocol text fields - #9398
Draft
Andezion wants to merge 2 commits into
Draft
common: reject banned Unicode categories in protocol text fields#9398Andezion wants to merge 2 commits into
Andezion wants to merge 2 commits into
Conversation
Andezion
force-pushed
the
fix/reject-banned-unicode-text-fields
branch
from
August 10, 2026 15:53
d4c14fe to
70836da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the null-byte/control-character ban discussed in lightning/bolts#1260:
utf8_check()previously only validated UTF-8 encoding, not content - null bytes, control characters, Unicode format characters (including bidirectional-override characters used in "Trojan Source" spoofing, CVE-2021-42574), private-use, and unassigned codepoints all passed silentlyChanges
from the Unicode Character Database (via
devtools/gen-unicode-category.py), mirroring the approachrust-lightning took.
Cs(surrogates) is excluded sinceccan/utf8already rejects those while decodingutf8_check(), the single chokepoint used by BOLT11 (description) and BOLT12 (offer_description,offer_issuer,invreq_payer_note,proof_note,invoice_error.msg) encoding/decodingtowire_utf8_array()already assertedutf8_check()on outgoing fields. With the stricter check, that assert became reachable from ordinary RPC input -offer/invoicerequest/fetchinvoice/cancelrecurringinvoicewould crash instead of failing cleanly. Addedparam_escaped_utf8_string()/param_utf8_string()to validate at the RPC boundary with a normalcommand_fail_badparamerrorTesting
New unit tests (
run-utils-utf8_check, additions torun-param) cover NUL/control/format/private-use/unassigned rejection and valid multi-byte UTF-8 passthrough. No regressions in existing BOLT11/ BOLT12 test suites. Verified clean under ASan+UBSan.Important
26.09 FREEZE August 5th: Non-bugfix PRs not ready by this date will wait for 26.12.
RC1 is scheduled on August 17th
The final release is scheduled for September 7th.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
tools/lightning-downgrade