Fix: LFG Reminder never firing on non-English/Russian clients - #1908
Open
svart2521 wants to merge 1 commit into
Open
Fix: LFG Reminder never firing on non-English/Russian clients#1908svart2521 wants to merge 1 commit into
svart2521 wants to merge 1 commit into
Conversation
Bug: Issue: QoL's LFG Reminder popup silently never fired on a German client (and every other locale besides English/Russian) because TELEPORT_BY_NAME was seeded only from a hardcoded English/Russian alias list, while the joined LFGList activity's fullName comes back in the client's own locale and never matched. Fix: For each SEASON_PORTALS entry, also seed TELEPORT_BY_NAME with GetLFGDungeonInfo(dungeonID)'s live, client-locale dungeon name (pcall-wrapped), so the lookup self-corrects for every client locale automatically instead of relying on hardcoded translations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: https://discord.com/channels/585577383847788554/1544272017027633213
Issue: QoL's LFG Reminder popup silently never fired on a German client (and every other locale besides English/Russian) because TELEPORT_BY_NAME was seeded only from a hardcoded English/Russian alias list, while the joined LFGList activity's fullName comes back in the client's own locale and never matched.
Fix: For each SEASON_PORTALS entry, also seed TELEPORT_BY_NAME with GetLFGDungeonInfo(dungeonID)'s live, client-locale dungeon name (pcall-wrapped), so the lookup self-corrects for every client locale automatically instead of relying on hardcoded translations.