Skip to content

Remove the ELRS handset address distinction - #21

Open
Itay-Sharoni wants to merge 1 commit into
ExpressLRS:unified-lua-lspfrom
Itay-Sharoni:handset-address
Open

Remove the ELRS handset address distinction#21
Itay-Sharoni wants to merge 1 commit into
ExpressLRS:unified-lua-lspfrom
Itay-Sharoni:handset-address

Conversation

@Itay-Sharoni

Copy link
Copy Markdown

Fixes #12

ExpressLRS/ExpressLRS#3680 (4.1) removed the special Lua address 0xEF from
the firmware together with the Bad/Good parameter it existed for. The
package still asks the ELRS TX as 0xEF and every other device as 0xEA.

Use the standard handset address 0xEA for everything, like the r18 lua:
drop the constant and the per-device switch in setDevice, and send the
status request as 0xEA as well.

As with the r18 lua, modules older than 4.1 now show their static Bad/Good
info row; the counts in the header keep updating as before. The 1.x
detection is unaffected: 3.x+ firmware never writes to the handset, and
the r18 lua already runs the same check on 0xEA.

Checked against the CRSFSimulator (all frames carry 0xEA, loading and
commands unchanged) and on a TX15 and a Boxer with 4.1.x modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant