Remove the ELRS handset address distinction - #21
Open
Itay-Sharoni wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12
ExpressLRS/ExpressLRS#3680 (4.1) removed the special Lua address 0xEF from
the firmware together with the Bad/Good parameter it existed for. The
package still asks the ELRS TX as 0xEF and every other device as 0xEA.
Use the standard handset address 0xEA for everything, like the r18 lua:
drop the constant and the per-device switch in setDevice, and send the
status request as 0xEA as well.
As with the r18 lua, modules older than 4.1 now show their static Bad/Good
info row; the counts in the header keep updating as before. The 1.x
detection is unaffected: 3.x+ firmware never writes to the handset, and
the r18 lua already runs the same check on 0xEA.
Checked against the CRSFSimulator (all frames carry 0xEA, loading and
commands unchanged) and on a TX15 and a Boxer with 4.1.x modules.