Retry SQLite contention through decorated database handles - #1240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1239
Summary
wpdb->last_errorinstead of the outer database classworkspace_sqlite_lock_contentionexhaustion contractVerification
php tests/workspace-lock-sqlite-contention.phpphp -l inc/Storage/SqliteBusyRetry.phpphp -l tests/workspace-lock-sqlite-contention.phpgit diff --checkAI assistance
OpenAI GPT-5.6 Sol via OpenCode reproduced the live managed-worktree failure, traced the decorated database boundary, implemented result-driven contention retry, and added the deterministic decorated-backend regression. Chris Huber directed the repair and remains responsible.