Keep .github out of the release tarball - #12
Merged
Conversation
The workflow directory added in #11 is tracked, and the release asset is a git archive of the tag, so without an export-ignore it unpacks into the web root as lib/plugins/.github/workflows/tests.yml. That is the same reason README.md, LICENSE and tests/ are already excluded: the installer untars this straight into a directory the web server serves. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017aBSWrDArXHTpKWkkN27LR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/workflows/tests.ymllanded in #11 and is tracked, but the release asset is agit archiveof the tag — so without anexport-ignorethe next release unpacks a.github/workflows/directory into every FOG web root aslib/plugins/.github/workflows/tests.yml.That is exactly the case the existing exclusions are there for; the comment at the top of
.gitattributesalready says why ("the installer untars this straight intolib/plugins, so anything exported here ends up served by the web server").README.md,LICENSE,.gitattributes,make-release.shandtests/are already excluded —.github/was simply missed because it did not exist when the list was written.Caught while preparing the v1.6.6 release that ships the OIDC provider-group tabs from #10.
🤖 Generated with Claude Code
https://claude.ai/code/session_017aBSWrDArXHTpKWkkN27LR