Publish the generated version on the working-1.6 badge - #41
Merged
Merged
Conversation
A branch that carries .githooks/lib/write-version-file.sh skips the compute step, so the badge step read two unset outputs and wrote an empty message. shields.io rejects that as "invalid properties: message", and the Beta badge in the fogproject README has been broken since 2026-08-30. The badge step now runs the branch's own write-version-file.sh, the same generator bin/installfog.sh uses, and reads FOG_VERSION back out of packages/web/commons/version.php. An empty version fails the step instead of publishing a broken badge. The job summary no longer reports an empty version as "already correct" on those branches. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RANCjBL6XSavKYf58MZKZj
Member
Author
|
Dispatch from this branch (run 34511435938, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Beta badge in the fogproject README renders "custom badge: invalid properties: message".
badges/working-1.6.jsoncarries"message": "".Cause
working-1.6 carries
.githooks/lib/write-version-file.sh, so the sweep skips the compute step there (#39). The badge step still readsteps.commit.outputs.final_version || steps.compute.outputs.version. Both are unset on that branch, so it published an empty message. shields.io rejects an empty message.Fix
write-version-file.sh, the same generatorbin/installfog.shuses, and readsFOG_VERSIONfrompackages/web/commons/version.php.CLAUDE.mddescribes the new badge source.Verification
--filter=blob:noneclone of working-1.6 ate69ef2cc9:1.6.0-beta.5360. This matches the installer's ownawkread of the same file andmaster..HEAD --count.branch=working-1.6,version_only=true. Result below.Not in this PR
The sweep has also failed daily on dev-branch since 2026-09-06. The tag
archive/feature-fog2-guiis now the newest tag, sofog-version.shcomputesarchive/feature-fog2-gui.2480andsedfails on the slash. The fix belongs in fogproject'sfog-version.shand goes in separate PRs there.🤖 Generated with Claude Code
https://claude.ai/code/session_01RANCjBL6XSavKYf58MZKZj