Skip to content

[Plugin] Add fpp-ExternalFPP - #244

Open
github-actions[bot] wants to merge 1 commit into
masterfrom
add-plugin/fpp-ExternalFPP
Open

github-actions[bot] wants to merge 1 commit into
masterfrom
add-plugin/fpp-ExternalFPP

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Adds fpp-ExternalFPP to pluginList.json, requested in #243.

Plugin repo: https://github.com/jessica12ryan/fpp-ExternalFPP
pluginInfo.json: https://raw.githubusercontent.com/jessica12ryan/fpp-ExternalFPP/refs/heads/main/pluginInfo.json
Category: Monitoring & System Tools
Submitted by: @jessica12ryan
Registered owner (from srcURL): @jessica12ryan (matches submitter)

✅ The automated plugin check passed - no blocking issues found.

Schema, category, and archived/issues-disabled were already checked before this PR existed.

Merging is entirely up to a maintainer's judgement - this PR being open is not an approval, especially if it was opened via /submit over unresolved findings above.

⚠️ Before merging: install this plugin on a real (or test) FPP instance and visually inspect it - the automated check only covers what it can grep for. Confirm the UI actually renders correctly in both light and dark theme, nothing looks broken, and there's nothing the automated findings above wouldn't catch (ads, phone-home, donation links, ...).

A repo maintainer (or @jessica12ryan) can comment /recheck here to re-run the plugin check against the repo's current state and refresh the findings above.

@darylc

darylc commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Heads-up: since this PR's last scan, the listing check gained a privacy disclosure.

We did this because plugins have changed: with AI writing much of the code they've grown far more complex, and far more of them now integrate with internet services, open remote access or bundle VPNs and tunnels — all of it running as root on a device inside someone's home. Until now a user had no way to know any of that before clicking Install.

So every listed plugin's pluginInfo.json now needs a privacy block - a plain-language statement of what the plugin sends and to whom, what it collects and about whom, any sensors, its own remote access, what it changes on the device, and whether all its code can be checked. FPP 10.1 turns it into six lights on the install dialog, with your summary and details underneath, so the choice is the user's. Without a block the dialog shows "No privacy disclosure" and the listing check reports privacy-missing - which is why the "ready" result earlier in this PR is out of date.

Please review the following:

Add the block on the branch this PR lists, then comment /recheck here for a fresh report

@github-actions

Copy link
Copy Markdown
Contributor Author

🔄 Recheck

Plugin: fpp-ExternalFPP
Repo: https://github.com/jessica12ryan/fpp-ExternalFPP
Owner: jessica12ryan

Requested by @darylc - 1 issue(s) currently outstanding:

  • 🛑 Blocker - privacy-undeclared-selfupdate - an install/start hook updates the plugin's own checkout (scripts/fpp_install.sh:49: git -C "${PLUGIN_DIR}" reset --hard origin/main 2>/dev/null || true) but the pluginInfo.json privacy block doesn't declare it.
    • Add a systemChanges entry of kind "download" ("updates itself from GitHub at every start") - better, remove it: FPP's upgrade path installs the pinned sha, and a hook that resets to origin makes the listed version meaningless

This comment reflects the repo's current state; it does not change the PR itself - merging is still a maintainer's call.

@jessica12ryan

Copy link
Copy Markdown

/recheck

@github-actions

Copy link
Copy Markdown
Contributor Author

🔄 Recheck

Plugin: fpp-ExternalFPP
Repo: https://github.com/jessica12ryan/fpp-ExternalFPP
Owner: jessica12ryan

✅ Requested by @jessica12ryan - no blocking issues found.

This comment reflects the repo's current state; it does not change the PR itself - merging is still a maintainer's call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants