Skip to content

[Plugin] Add FPP-Plugin-DailyShowCountdown - #268

Open
github-actions[bot] wants to merge 1 commit into
masterfrom
add-plugin/FPP-Plugin-DailyShowCountdown
Open

github-actions[bot] wants to merge 1 commit into
masterfrom
add-plugin/FPP-Plugin-DailyShowCountdown

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Adds FPP-Plugin-DailyShowCountdown to pluginList.json, requested in #267.

Plugin repo: https://github.com/colinedwards308/FPP-Plugin-DailyShowCountdown
pluginInfo.json: https://raw.githubusercontent.com/colinedwards308/FPP-Plugin-DailyShowCountdown/refs/heads/main/pluginInfo.json
Category: Messaging, Signage & Countdown
Submitted by: @colinedwards308
Registered owner (from srcURL): @colinedwards308 (matches submitter)

✅ The automated plugin check passed - no blocking issues found.

Schema, category, and archived/issues-disabled were already checked before this PR existed.

Merging is entirely up to a maintainer's judgement - this PR being open is not an approval, especially if it was opened via /submit over unresolved findings above.

⚠️ Before merging: install this plugin on a real (or test) FPP instance and visually inspect it - the automated check only covers what it can grep for. Confirm the UI actually renders correctly in both light and dark theme, nothing looks broken, and there's nothing the automated findings above wouldn't catch (ads, phone-home, donation links, ...).

A repo maintainer (or @colinedwards308) can comment /recheck here to re-run the plugin check against the repo's current state and refresh the findings above.

@colinedwards308

Copy link
Copy Markdown

Thanks! The optional lifecycle check has also been verified with an actual uninstall/reinstall on FPP 10.0, Raspberry Pi. All three countdown commands disappeared on uninstall and returned automatically on reinstall, without restarting FPP—the process ID and start time remained unchanged.

Results are documented in docs/VALIDATION.md.

Thank you for reviewing the plugin. I created it for a need I had. I'm sure others will be able to use it as well. Please let me know if any further changes are needed.

@darylc

darylc commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Heads-up: since this PR's last scan, the listing check gained a privacy disclosure.

We did this because plugins have changed: with AI writing much of the code they've grown far more complex, and far more of them now integrate with internet services, open remote access or bundle VPNs and tunnels — all of it running as root on a device inside someone's home. Until now a user had no way to know any of that before clicking Install.

So every listed plugin's pluginInfo.json now needs a privacy block - a plain-language statement of what the plugin sends and to whom, what it collects and about whom, any sensors, its own remote access, what it changes on the device, and whether all its code can be checked. FPP 10.1 turns it into six lights on the install dialog, with your summary and details underneath, so the choice is the user's. Without a block the dialog shows "No privacy disclosure" and the listing check reports privacy-missing - which is why the "ready" result earlier in this PR is out of date.

Please review the following:

Add the block on the branch this PR lists, then comment /recheck here for a fresh report

@github-actions

Copy link
Copy Markdown
Contributor Author

🔄 Recheck

Plugin: FPP-Plugin-DailyShowCountdown
Repo: https://github.com/colinedwards308/FPP-Plugin-DailyShowCountdown
Owner: colinedwards308

Requested by @darylc - 1 issue(s) currently outstanding:

  • 🛑 Blocker - privacy-missing - pluginInfo.json has no privacy block - FPP builds the install dialog's privacy lights (Sends data, Collects data, Camera & mic, Remote access, System changes, Can it be checked?) from it, and without one the dialog says "No privacy disclosure".
    • Add the block (eight keys, all required, empty arrays allowed; see the privacy section of pluginInfo.schema.json and PLUGIN_GUIDELINES.md §14). Every listed plugin must carry one, so this blocks the listing

This comment reflects the repo's current state; it does not change the PR itself - merging is still a maintainer's call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants