Skip to content

performance pass - #121

Open
halfcyan wants to merge 7 commits into
cypress/ch-abstractionfrom
cypress/performance-pass
Open

performance pass#121
halfcyan wants to merge 7 commits into
cypress/ch-abstractionfrom
cypress/performance-pass

Conversation

@halfcyan

Copy link
Copy Markdown
Member

i just wanted to do a larger pass of everything performance-wise since small improvements add up in a system like this


Stack created with GitHub Stacks CLIGive Feedback 💬

@halfcyan

Copy link
Copy Markdown
Member Author

added the benchmarking stuff to see how much this improves stuff and uh. wow.

VM count Before: full scan After: delta construction Approx. speedup
10 116 µs 51 µs 2.3x
100 752 µs 41 µs 18.4x
1,000 5.91 ms 42 µs 140x
10,000 57.83 ms 41 µs 1,412x
100,000 567.92 ms 41 µs 13,795x

@halfcyan
halfcyan force-pushed the cypress/performance-pass branch from 0910116 to 4d14227 Compare August 23, 2026 15:56
@halfcyan

Copy link
Copy Markdown
Member Author

the biggest thing is that the heartbeat resource calc changed from O(VMs) to O(1) which is massive

@TheHeroBrine422 TheHeroBrine422 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like the ideas, but there are minor issues.

On top of this, scheduler_actor.rs is getting really hard to follow. We need better documentation and/or to split the module into several parts.

@korewaChino should likely review the ch_driver changes since I am not super familar with that section of the codebase, although it looks fine to me.

Comment thread odorobo/src/actors/scheduler_actor.rs Outdated
Comment thread odorobo/src/actors/scheduler_actor.rs
Comment thread odorobo/src/actors/scheduler_actor.rs
Comment thread odorobo/src/actors/scheduler_actor.rs Outdated
@halfcyan
halfcyan force-pushed the cypress/performance-pass branch from 4d14227 to a319bc2 Compare August 27, 2026 22:46
Comment thread odorobo/src/actors/agent_actor.rs Fixed
Comment thread odorobo/src/actors/agent_actor.rs Fixed
@halfcyan
halfcyan force-pushed the cypress/performance-pass branch 2 times, most recently from 33af7a4 to 92a99d2 Compare August 28, 2026 00:25
@TheHeroBrine422
TheHeroBrine422 force-pushed the cypress/performance-pass branch from 92a99d2 to e64114b Compare August 28, 2026 01:11
@halfcyan
halfcyan force-pushed the cypress/performance-pass branch from e64114b to 030bb09 Compare August 28, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants