Fix division by zero (NaN) in gmt_extend_region when +r/+e increment is 0 - #9127
Open
Esteban82 wants to merge 1 commit into
Open
Fix division by zero (NaN) in gmt_extend_region when +r/+e increment is 0#9127Esteban82 wants to merge 1 commit into
Esteban82 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done with Claude Sonnet 5
Problem
-Rcode+r<inc>and-Rcode+e<inc>allow specifying 0 for one axis to mean "don't adjust that axis" (e.g. +e1/0 to only round/extend in x). However,gmt_extend_region()divided byinc[...]unconditionally when rounding to multiples of the increment, so a 0 increment produced a division by zero →-nanpropagated into the resulting region(wesn[YLO]/wesn[YHI]).Fix
In
gmt_extend_region(), skip the floor/ceil rounding for any axis whose increment is 0, leaving that axis's bound untouched instead of dividing by zero.Tested with
The figure is now generated correctly, and the region is reported correctly in the terminal:
Closes #6434