Wrap fitcircle - #1550
Conversation
| S="small_circle", | ||
| ) | ||
| def fitcircle( | ||
| data: PathLike | TableLike, |
There was a problem hiding this comment.
Should support parameters x/y, too.
| $table_classes. | ||
| $output_type | ||
| $outfile | ||
| norm : int or bool |
There was a problem hiding this comment.
1, 2, 3 are not readable arguments. GMT recommends absolutes/squares/both instead.
As for the parameter, GMT supports norm and solution, while GMT.jl uses norm (https://www.generic-mapping-tools.org/GMTjl_doc/documentation/modules/fitcircle.html).
|
@willschlitzer Could you please an issue for tracking this module, using the template at https://github.com/GenericMappingTools/pygmt/blob/main/.github/ISSUE_TEMPLATE/3-module_request.md |
|
|
Their combinations can lead to quite different output formats, as shown below: The current implementation always returns a pandas.DataFrame object, which is not Pythonic, and also makes it difficult to implement the As mentioned in #1550 (comment), I propose
Internally, we can just call |
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
This pull request wraps the module
fitcircle.Preview at https://pygmt-dev--1550.org.readthedocs.build/en/1550/api/generated/pygmt.fitcircle.html
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version