Skip to content

test: added a new unit tests to validate the cases like '"": "gts://gtx.x.test6.invalid_uri_body.bad_prefix.v1~"' - #117

Open
Artifizer wants to merge 1 commit into
mainfrom
new-tests
Open

test: added a new unit tests to validate the cases like '"": "gts://gtx.x.test6.invalid_uri_body.bad_prefix.v1~"'#117
Artifizer wants to merge 1 commit into
mainfrom
new-tests

Conversation

@Artifizer

@Artifizer Artifizer commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Tests
    • Added coverage confirming that schemas using a gts:// identifier are rejected when their body has an invalid prefix.

…tx.x.test6.invalid_uri_body.bad_prefix.v1~"'

Signed-off-by: Artifizer <artifizer@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: efb08e2b-2601-4a75-b2f8-da274d338573

📥 Commits

Reviewing files that changed from the base of the PR and between 97af7a7 and b8e4c98.

📒 Files selected for processing (1)
  • gts/src/ops.rs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Adds a test that verifies add_entity rejects a schema with a gts:// identifier whose body starts with gtx..

Changes

GTS validation

Layer / File(s) Summary
Invalid URI body validation
gts/src/ops.rs
Adds coverage for an invalid gts:// schema identifier and checks for the "Unable to detect GTS ID" error.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to b8e4c

This adds coverage ensuring schemas with an invalid gts:// identifier body are rejected. It does not change runtime behavior, and no merge-blocking risk remains.

Suggested reviewers: aviator5

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title refers to the added test, but it is grammatically unclear and focuses on a malformed example instead of stating that the test validates rejection of an invalid GTS URI body prefix.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch new-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@code-ranker-app

Copy link
Copy Markdown
Contributor

code-ranker: 4 findings View report ↗

rust: 4 findings
🤖 Prompt for fix all with AI
Run `code-ranker check --top 1` and follow instructions to fix error. Loop until no errors left.

updated 2026-09-06 10:06 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant