Fix broken trace behavior for non-closed paths - #511
Open
jeffc wants to merge 2 commits into
Open
Conversation
…or any follow operation in op-area)
…ations) and correct them if necessary This ensure that "inside" and "outside" work as expected for open paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two bugs in trace operations for open paths:
I've attached an example workspace that traces a single segment on a part. In the current version of kiri:moto, no toolpaths are generated. If you apply the first commit in this PR, the toolpath gets generated inside the part even though "outside" is selected. When you apply both commits, it works as expected.
note: I discovered #510 while writing this, which is why
.rightgot switched to.leftinpolygons.js. I figured I'd stick with the current convention rather than try to fix the whole thing as part of this PR.workspace_key_offset_example.zip