Allow null-returning do expressions with failOnUnknownTokens - #1334
Open
alloutflo wants to merge 1 commit into
Open
Allow null-returning do expressions with failOnUnknownTokens#1334alloutflo wants to merge 1 commit into
alloutflo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nullresult withfailOnUnknownTokensonly when the complete expression is a successful method callFixes #1259.
Testing
FailOnUnknownTokens,DoTag, and eagerDoTagtests: 15 passedmvn verifyunder JDK 23 with Java release 17 and an expliciten_UStest locale: 2,220 tests passed, 23 skippedAI assistance disclosure
OpenAI Codex was used to analyze, implement, and test this change. The diff and checks listed above were verified in the contribution workspace.