ci: move the actions off the deprecated node20 runtime - #26
Merged
Conversation
actions/checkout@v4 and actions/setup-node@v4 declare runs.using: node20, so every job printed the Node 20 deprecation notice while GitHub force-ran them on Node 24 anyway. Both current majors declare node24. This is the runtime the runner uses to execute an action's own JavaScript. It is unrelated to matrix.node-version and to engines: the Node the package is tested on is unchanged. Nothing here trips the majors' breaking changes. checkout v7 blocks fork-PR checkout under pull_request_target and workflow_run, and all four workflows trigger on pull_request. checkout v6 persists credentials to a separate file, and nothing pushes from CI. setup-node v6 limits automatic caching to npm, and every job already sets cache: npm explicitly. Closes #25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25.
Every CI job printed:
actions/checkout@v4andactions/setup-node@v4declareruns.using: node20in theiraction.yml. GitHub force-runs those on Node 24 and emits the notice.github/codeql-action@v4was already onnode24and is untouched.Behaviour changes
None for the package. The bumped runtime is the Node the runner uses to execute an action's own JavaScript — it is unrelated to
matrix.node-versionand toengines.test.ymlstill runs the suite on Node 22 and 24, andenginesstill says>=22.19; neither line is in the diff.The only visible change is that the deprecation notice stops appearing in job logs.
Breaking changes in the skipped majors
Each was checked against these workflows:
pull_request_target/workflow_runpull_requesttypes.ymlonly runsgit diffcache: npmexplicitlyVerification
npm run lint,npm test(581 passed),npm run generate-types,npm run check-typesall pass. The real check is this PR's own CI run: the four jobs should be green with no deprecation notice.Not included
.github/skills/ci-cd-and-automation/SKILL.mdstill shows@v4in its example snippets. It is vendored plugin documentation rather than CI, so it emits no warning — but it will keep suggesting the deprecated versions. There is also no.github/dependabot.yml, so nothing will catch the next runtime deprecation automatically. Both are separate changes.