Skip to content

fix: CLI banner advertised queries the chat tools cannot serve - #127

Open
atc964 wants to merge 1 commit into
mainfrom
fix/cli-banner-examples
Open

atc964 wants to merge 1 commit into
mainfrom
fix/cli-banner-examples

Conversation

@atc964

@atc964 atc964 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

The defect

The interactive chat command's welcome banner (interfaces/cli/main.py) suggested example queries none of which the chat tools can serve: "Search for CTV inventory under $20 CPM", "What branding options are available?", and "Help me plan a campaign for $50,000". The chat agent's only tools are request_quotes and book_deals, both keyed on a product ID; there is no open-ended inventory search or browsing capability.

What changed

  • Replaced the three example queries in the chat welcome banner with ones the chat can actually fulfill: requesting a quote for a product ID, booking a product within a budget, and asking about currently connected sellers.
  • Kept the panel's existing formatting and tone; only the false examples changed.
  • Grepped interfaces/cli/main.py for other stale capability claims. The rest of the file's inventory/campaign language belongs to the separate search and book CLI commands (OpenDirect product search, campaign-brief-driven booking flow), which are real, working commands unrelated to the chat tool set, so nothing else needed to change.

Scope note

This completes the companion fix called out in #126 (fix/chat-prompt-dead-tool), which rewrote the chat's per-turn prompt to describe request_quotes and book_deals honestly but deferred the CLI banner fix because interfaces/cli/main.py was under a code freeze from an in-flight PR (#125, auth/key management). That PR has since merged to main, so this picks up the deferred half.

Test evidence

  • ruff check and ruff format --check on the changed file: clean.
  • Full tests/unit suite: 3500 passed, 1 skipped, in about 91 seconds.

The chat welcome banner suggested open-ended queries like searching
CTV inventory under a CPM cap, listing branding options, or planning
a campaign by budget. The chat interface's only tools, request_quotes
and book_deals, are both product-ID keyed and cannot serve any of
those. Replace the examples with queries the chat can actually
fulfill: requesting a quote for a product ID, booking within a
budget, and asking about connected sellers.
@atc964
atc964 requested a review from Kishore-2572 September 14, 2026 19:35

@Kishore-2572 Kishore-2572 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: 3610 passed, 83 skipped, 0 failed — identical to main's baseline, as expected for a
text-only banner change. Confirmed the chat agent's only tools are request_quotes/book_deals,
both keyed on product ID, so the replaced example queries are accurate to what the tool set can
actually serve. Correctly scoped as the deferred companion half of #126, now unblocked since #125
merged. Approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants