-
Notifications
You must be signed in to change notification settings - Fork 12
Add request phase timing: Server-Timing subtimings and access telemetry #1074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jevansnyc
wants to merge
20
commits into
main
Choose a base branch
from
feat/request-phase-timing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
cf16418
Add request phase timing design spec and implementation plan (#1069)
jevansnyc 052eada
Add RequestTimings phase collection and Server-Timing rendering
jevansnyc 7505fb8
Add observability settings and decouple tinybird access and auction e…
jevansnyc 4ce413f
Add test coverage for the access_enabled without tinybird.enabled rej…
jevansnyc f83092a
Emit Server-Timing at the send freeze point on conclusively private r…
jevansnyc 4b19c44
Record filter and geo spans and dedupe the per-request geo lookup
jevansnyc ce295f1
Record origin, template cache, and KV phase spans in core
jevansnyc c222ae2
Capture stream duration, auction wait placement, and response bytes
jevansnyc 8b028bb
Add access telemetry snapshot, route classes, and coarse route templates
jevansnyc 48acd81
Emit confirmed access telemetry rows after pull-sync post-send
jevansnyc 72d5755
Extend access_logs_raw with phase columns and a non-null sorting key
jevansnyc c50be03
Widen time_elapsed_ms to nullable so dropped snapshots cannot quarant…
jevansnyc 0aead79
Emit Server-Timing from the Axum terminal layer with adapter-specific…
jevansnyc e9cf5b9
Document the observability and access telemetry configuration surface
jevansnyc 7942c74
Normalize telemetry method, guard zero sample rate, and mirror geo wr…
jevansnyc d8fcb5e
Add a local dev config envelope generator example
jevansnyc 7cf7d86
Add JSONPaths and expression sorting key to the access datasource
jevansnyc 600746f
Use web_time Instant on request timing paths
jevansnyc 3d7e697
Reject opaque identifier segments in publisher route templates
jevansnyc 38043d7
Address access telemetry review feedback
jevansnyc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
♻️ P3 — Do not discard timing configuration in the standard Axum application path
TimingServiceis not part of the returnedRouterService, so callers using the existingHooks::routes()orHooks::build_app()interface get a different application from the shipped binary and silently ignoreserver_timing_enabled. The tuple is also an opaque public construction API whose Boolean is meaningful only to the custom runner.The outer service is justified here chiefly by router-generated 404/405 responses, but those responses also bypass finalization and are not conclusively private; the 404 test has to manufacture a private response. Please consider using an outermost EdgeZero timing middleware. If the Tower wrapper is genuinely required, expose a named, fully configured application/service and make that the standard construction path rather than returning
(RouterService, bool).