Skip to content

fix: Adapt alt text at the course sessions - #11856

Open
abrahammordev wants to merge 2 commits into
ILIAS-eLearning:release_10from
surlabs:ilias10_a11y_#M41480
Open

fix: Adapt alt text at the course sessions#11856
abrahammordev wants to merge 2 commits into
ILIAS-eLearning:release_10from
surlabs:ilias10_a11y_#M41480

Conversation

@abrahammordev

Copy link
Copy Markdown
Contributor

Hi everyone!

This PR addresses the following ticket: https://mantis.ilias.de/view.php?id=41480

I replaced the language variable used for the session button’s alt text with a new one and translated it into most of the languages supported by ILIAS.

Best,
Abraham

@abrahammordev abrahammordev added php Pull requests that update Php code accessibility Pull requests that propose A11Y changes. labels Aug 5, 2026
@oliversamoila

Copy link
Copy Markdown
Contributor

Hello everyone,
As far as I can see, this fulfils the request raised by @Annett7811.

As this is an accessibility improvement that is not part of the UI framework but is located in components/ILIAS/ILIASObject/classes, I am assigning @kergomard as the responsible authority.

A long-term solution for sessions and item groups (and potentially others) will be addressed in the next step with #11788, but this does not yet fully resolve everything.

My view is therefore that we should go ahead with these minor accessibility improvements until we have something even better. However, Stephan should please review the change in the code.

Best regards,
Oliver

@oliversamoila
oliversamoila requested review from kergomard and removed request for thibsy August 19, 2026 08:37
@oliversamoila oliversamoila added bugfix translations Pull requests that propose changes to ILIAS language files. labels Aug 19, 2026

@kergomard kergomard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi all

I'm sorry, I'm not going to accept this change. I know this looks minimal and it is, but it is still wrong. You are introducing knowledge of a sub-class in a parent class. This cannot be it. If you need there to be another variable you have to restructure this code in a way that the corresponding change can be made in the ListGUI of the session or just duplicate the function there.

Thanks and best,
@kergomard

@abrahammordev

Copy link
Copy Markdown
Contributor Author

Hi @kergomard ,

Thanks a lot for the feedback. I’ve changed the implementation to follow a cleaner approach, avoiding the need to introduce subclass-specific knowledge into the parent class.

The session specific behaviour is now implemented in ilObjSessionListGUI.
I hope this approach aligns with your guidelines.

Best,
Abraham

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility Pull requests that propose A11Y changes. bugfix php Pull requests that update Php code translations Pull requests that propose changes to ILIAS language files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants