fix: Adapt alt text at the course sessions - #11856
Conversation
|
Hello everyone, As this is an accessibility improvement that is not part of the UI framework but is located in A long-term solution for sessions and item groups (and potentially others) will be addressed in the next step with #11788, but this does not yet fully resolve everything. My view is therefore that we should go ahead with these minor accessibility improvements until we have something even better. However, Stephan should please review the change in the code. Best regards, |
kergomard
left a comment
There was a problem hiding this comment.
Hi all
I'm sorry, I'm not going to accept this change. I know this looks minimal and it is, but it is still wrong. You are introducing knowledge of a sub-class in a parent class. This cannot be it. If you need there to be another variable you have to restructure this code in a way that the corresponding change can be made in the ListGUI of the session or just duplicate the function there.
Thanks and best,
@kergomard
|
Hi @kergomard , Thanks a lot for the feedback. I’ve changed the implementation to follow a cleaner approach, avoiding the need to introduce subclass-specific knowledge into the parent class. The session specific behaviour is now implemented in Best, |
Hi everyone!
This PR addresses the following ticket: https://mantis.ilias.de/view.php?id=41480
I replaced the language variable used for the session button’s alt text with a new one and translated it into most of the languages supported by ILIAS.
Best,
Abraham