ItemGroup 45702: Prevent invalid item group memberships - #12064
Merged
Merged
Conversation
See: https://mantis.ilias.de/view.php?id=45702 Item groups could keep `item_group_item` rows for references that no longer lived under the container, and items were still offered after objects were trashed or deleted. `ilItemGroupAppEventListener` reacts to ILIAS object `toTrash` and `delete` events by calling `ilItemGroupItems::removeItemGroupAssociations`. Persisted assignments are intersected with actual tree children when loading, `getValidItems` validates against assignable refs, cloning copies only valid refs, and `ilItemGroupItemsTableGUI` reflects that filtered set in the materials table.
matheuszych
force-pushed
the
igr10/45702
branch
from
September 14, 2026 13:50
51a6795 to
ad1ecac
Compare
Contributor
|
Hey @matheuszych, thanks for the PR. I've integrated the changes into release_10, release_11 and trunk. Kind regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://mantis.ilias.de/view.php?id=45702
Item groups could keep
item_group_itemrows for references that no longer lived under the container, and items were still offered after objects were trashed or deleted.ilItemGroupAppEventListenerreacts to ILIAS objecttoTrashanddeleteevents by callingilItemGroupItems::removeItemGroupAssociations. Persisted assignments are intersected with actual tree children when loading,getValidItemsvalidates against assignable refs, cloning copies only valid refs, andilItemGroupItemsTableGUIreflects that filtered set in the materials table./cc @thojou