Fix 122 bespoke measurement configurations - #123
Open
dehoni wants to merge 3 commits into
Open
Conversation
dehoni
commented
Aug 11, 2026
| def do_trans(self, title=None, pos=None, thickness=1.0, dae="transmission", | ||
| aperture="", period=None, time=None, dls_sample_changer=False, **kwargs): | ||
| """A wrapper around ``measure`` which ensures that the instrument is | ||
| in transition mode before running the measurement if a title is given. It ensures that the |
Contributor
Author
There was a problem hiding this comment.
do_sans and do_trans should have default. Some people setup the instrument with do_trans or do_sans and then just do a begin to quickly check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instrument(s)
ZOOM
Story/Acceptance criteria
As an instrument scientist it would be nice to have predefined configurations that setup the instrument always in a predicable way. This can be standard measurement modes (4m,8m) or more complex measurements like polarised beam experiments where one would switch between different flipper states. Also I would like to engage the ISIS and chopper vetos before a measurement to ensure that the data are valid.
Issue/Ticket Reference
Fixes issue 122 #122
Code Review
Final Steps