Pythonic script writer - #2
Open
dehoni wants to merge 90 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a python rewrite of the script_writer for generating instrument scripts used by LARMOR, SANS2D and LOQ.
What changed
Implemented core script generation routines. The table of the script writer has also a few new tools (e.g. to populate whole rows etc). It is designed to be a non-breaking (and rather subtle) change for existing users.
Why
Makes the working of the script writer easier to understand and read by using a language which everyone in the group has some kind of knowledge. Improves testability and confidence in output and potential issues can be quicker resolved.
How to test
1)Checkout the branch: git checkout pythonic_script_writer
2)Build the solution: see Readme.md for instructions
3)Create example for typical scripts and confirm the generated script(s) match expected output.
Related issues
#1