Fix RGB to sRGB conversion formulas in Command-line Options page - #155
Open
michaelbnewman wants to merge 1 commit into
Open
Fix RGB to sRGB conversion formulas in Command-line Options page#155michaelbnewman wants to merge 1 commit into
michaelbnewman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the process of fixing typos in the Command-line Options page, I found the formulas for converting RGB to sRGB need additional corrections:
.0.0031308to0.00313080.0031308to0.0031307to match source codeSource code involved:
https://github.com/ImageMagick/ImageMagick/blob/main/MagickCore/pixel.c#L445-L451
The source code includes usage of
QuantumRangeandQuantumScale, but those cancel out properly to match the documentation here as written.