Hi @hackermd . In #27 we had discussed making pillow and numpy optional. The issue was closed after these two dependencies were removed.
#56 reintroduced these required dependencies. #56 explicitly mentions in the description:
The DICOMfileClient depends on the NumPy and Pillow libraries. Therefore, this PR would introduce a dependency on C Python. I don't think this is a major issue and most users will likely have NumPy and Pillow installed anyways.
If this should turn out to be an issue, we could either
- make the dependencies optional (not a fan of that approach)
- put the DICOMfileClient into a separate package (also not ideal because the class is supposed to have the same API as the DICOMwebClient and having both in one package is advantageous in this regard)
As explained in #27:
I'm using this project (the library, not the CLI) as part of an application that will be running under pypy instead of cpython, possibly in an alpine container. I'd have to build both pillow & numpy for a feature I don't intend on using.
I would therefore kindly request that these dependencies are either changed to optional, or that the DICOMfileClient is split into a separate package (which can still of course be developed in this repo alongside DICOMwebClient) but installed separately from PYPI.
Hi @hackermd . In #27 we had discussed making pillow and numpy optional. The issue was closed after these two dependencies were removed.
#56 reintroduced these required dependencies. #56 explicitly mentions in the description:
As explained in #27:
I would therefore kindly request that these dependencies are either changed to optional, or that the
DICOMfileClientis split into a separate package (which can still of course be developed in this repo alongsideDICOMwebClient) but installed separately from PYPI.