issue/1519 - fix Ascend paged attention block index name collision - #1520
Open
ETOwang wants to merge 1 commit into
Open
issue/1519 - fix Ascend paged attention block index name collision#1520ETOwang wants to merge 1 commit into
ETOwang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #1519
Summary
block_idxidentifier.Root cause
Ascend C reserves
block_idxas a compiler built-in variable.The affected variables are logical page-block indices, not hardware
block IDs. The compiler therefore expands the declarations and reports
illegal initializer.Implementation
Renamed the local variables from
block_idxtopage_block_idx.No algorithm, operator interface, indexing formula, memory layout, or
output behavior was changed.
Testing
compile success
Environment